Skip to content

chore: prep app for v1.1.0-rc.1#3220

Merged
julienrbrt merged 1 commit intomainfrom
julien/prep-app
Mar 31, 2026
Merged

chore: prep app for v1.1.0-rc.1#3220
julienrbrt merged 1 commit intomainfrom
julien/prep-app

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Mar 31, 2026

Prep apps for v1.1.0-rc.1 of ev-node

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

The PR updates the EV-Stack project to depend on a new release candidate version (v1.1.0-rc.1) of the ev-node module across multiple application modules, disables local development replace directives, documents the release candidate in the changelog, and refreshes the Go toolchain and various library dependencies in development tools.

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Added new version entry for v1.1.0-rc.1 under the unreleased section with AWS & GCP KMS signer backend addition notes.
Application Module Dependencies
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
Updated github.com/evstack/ev-node from v1.0.0 to v1.1.0-rc.1 across all app modules; commented out local replace directives in evm and testapp to use remote module versions instead.
Development Tools Dependencies
tools/da-debug/go.mod
Upgraded Go toolchain from 1.25.6 to 1.25.7, bumped ev-node to v1.1.0-rc.1, and refreshed multiple direct dependencies (zerolog v1.34.0v1.35.0, go-libp2p v0.47.0v0.48.0, secp256k1/v4 v4.4.0v4.4.1); added numerous new indirect dependencies for Google Cloud, AWS SDK v2, OpenTelemetry, and related libraries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • tac0turtle

Poem

🐰 Hopping forward to v1.1.0-rc,
Dependencies dance in harmony,
Local paths fade, remote repos lead,
A toolchain refreshed for future speed! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal and lacks required context. While the title indicates the purpose (prep for v1.1.0-rc.1), the description body contains only a brief statement with no detailed overview, rationale, or explanation of changes. Add a more comprehensive description to the PR that explains the purpose of the version bump, what changes are being prepared, and the rationale for updating dependencies across multiple go.mod files.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main objective of the changeset: preparing the application for the v1.1.0-rc.1 release by updating dependencies and version references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/prep-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 31, 2026

Claude finished @julienrbrt's task in 1m 38s —— View job


Code Review: chore: prep app for v1.1.0-rc.1

  • Gather context and read changed files
  • Review CHANGELOG.md
  • Review go.mod changes (evm, grpc, testapp, da-debug)
  • Check version consistency across modules
  • Final summary

Summary

This is a clean release-prep PR with one notable inconsistency and a few minor observations.


⚠️ Inconsistent replace directive handling in apps/grpc/go.mod

apps/evm/go.mod and apps/testapp/go.mod correctly comment out their local replace directives for release:

// replace (
//     github.com/evstack/ev-node => ../../
// )

However, apps/grpc/go.mod still has active replace directives (unchanged from before):

replace (
    github.com/evstack/ev-node => ../../                                   // ← still active
    github.com/evstack/ev-node/execution/grpc => ../../execution/grpc     // ← still active
)

Even though the require line was updated to v1.1.0-rc.1, the active replace will override it and force the Go toolchain to use the local directory rather than the published module version. This is inconsistent with the intent of the other two apps and may cause apps/grpc to silently build against local code when consumed by downstream users.

Fix this →


Minor observations

CHANGELOG.md — the ## [Unreleased] section is left empty above ## v1.1.0-rc.1. This is the expected Keep a Changelog pattern and matches the format of previous release entries (e.g. ## v1.0.0 — no date, consistent).

tools/da-debug/go.mod — significant expansion of transitive indirect dependencies (AWS SDK, GCP KMS, OpenTelemetry, Viper, etc.). This is expected because ev-node v1.1.0-rc.1 added the AWS & GCP KMS signer backend (#3171), which pulls these in. No issues here, just worth being aware that the da-debug tool's dependency footprint has grown.

Version skewgithub.com/evstack/ev-node/core and github.com/evstack/ev-node/execution/grpc remain at v1.0.0/v1.0.0-rc.1 across all modules while ev-node bumps to v1.1.0-rc.1. Assuming those sub-modules were not changed in this release cycle, this is intentional.


Overall this looks good — the main thing to address is the un-commented replace directives in apps/grpc/go.mod.

@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 31, 2026, 2:06 PM

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/evm/go.mod (1)

5-8: Unify replace policy across app modules for consistent local dependency resolution.

Apps have mixed replace directives: apps/evm and apps/testapp disable local replace, while apps/grpc enables it. This causes dependency resolution to differ per app when developing locally—some resolve github.com/evstack/ev-node remotely while others use the local path.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/evm/go.mod` around lines 5 - 8, The project has inconsistent go.mod
replace directives causing mixed local vs remote resolution; update the replace
policy in apps/evm/go.mod to match the repo-wide convention (either enable the
local replace for github.com/evstack/ev-node and
github.com/evstack/ev-node/execution/evm or remove it everywhere). Edit the
replace block in the apps/evm go.mod (the entries referencing
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm) so it
is consistent with apps/grpc and apps/testapp—ensure all app modules either
include the local replace paths or none do, then run go mod tidy to verify
resolution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/evm/go.mod`:
- Around line 5-8: The project has inconsistent go.mod replace directives
causing mixed local vs remote resolution; update the replace policy in
apps/evm/go.mod to match the repo-wide convention (either enable the local
replace for github.com/evstack/ev-node and
github.com/evstack/ev-node/execution/evm or remove it everywhere). Edit the
replace block in the apps/evm go.mod (the entries referencing
github.com/evstack/ev-node and github.com/evstack/ev-node/execution/evm) so it
is consistent with apps/grpc and apps/testapp—ensure all app modules either
include the local replace paths or none do, then run go mod tidy to verify
resolution.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b66e4978-4277-4ae4-9a1e-46bdcaca8fd6

📥 Commits

Reviewing files that changed from the base of the PR and between 9290142 and 8f29309.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
  • tools/da-debug/go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • CHANGELOG.md
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod
  • tools/da-debug/go.mod

@julienrbrt julienrbrt merged commit 4a70e0b into main Mar 31, 2026
29 of 31 checks passed
@julienrbrt julienrbrt deleted the julien/prep-app branch March 31, 2026 14:07
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.40%. Comparing base (9290142) to head (8f29309).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   61.43%   61.40%   -0.04%     
==========================================
  Files         120      120              
  Lines       12504    12504              
==========================================
- Hits         7682     7678       -4     
- Misses       3960     3963       +3     
- Partials      862      863       +1     
Flag Coverage Δ
combined 61.40% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants